fix: Added missing package.json fields: license, bugs, repository - #123
fix: Added missing package.json fields: license, bugs, repository#123Omission-create wants to merge 1 commit into
Conversation
Greptile SummaryThis PR adds three missing
|
| Filename | Overview |
|---|---|
| package.json | Adds license, bugs, and repository fields, but bugs.url uses an unfilled placeholder (owner/repo) and repository.url is an empty string — both values are incorrect and need to be set to the actual repository URL. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[package.json metadata fields] --> B[license: MIT]
A --> C[bugs.url]
A --> D[repository.url]
C --> E[Placeholder owner/repo - should be devilsautumn/quater]
D --> F[Empty string - should be git+https://github.com/devilsautumn/quater.git]
Reviews (1): Last reviewed commit: "fix: Added missing package.json fields: ..." | Re-trigger Greptile
| "bugs": { | ||
| "url": "https://github.com/owner/repo/issues" | ||
| }, |
There was a problem hiding this comment.
The
bugs.url still uses the template placeholder owner/repo instead of the actual repository path (devilsautumn/quater). This means bug reports will be directed to a non-existent GitHub URL.
| "bugs": { | |
| "url": "https://github.com/owner/repo/issues" | |
| }, | |
| "bugs": { | |
| "url": "https://github.com/devilsautumn/quater/issues" | |
| }, |
| "repository": { | ||
| "type": "git", | ||
| "url": "" | ||
| } |
There was a problem hiding this comment.
The
repository.url is an empty string, which makes the field effectively useless. npm expects a valid git URL here (typically in git+https:// or git:// format). An empty value can cause tooling that reads this field to fail or produce incorrect output.
| "repository": { | |
| "type": "git", | |
| "url": "" | |
| } | |
| "repository": { | |
| "type": "git", | |
| "url": "git+https://github.com/devilsautumn/quater.git" | |
| } |
Auto-fix
Added missing package.json fields: license, bugs, repository
Related: #1319