-
Notifications
You must be signed in to change notification settings - Fork 24
feat(webapp): update SSH package with deprecated algorithm and keyboard interactive auth support #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the @devolutions/web-ssh-gui package from version 0.4.0 to 0.6.2, introducing support for keyboard-interactive authentication, deprecated SSH algorithms for legacy server compatibility, and fixes a deadlock issue between terminal visibility and host key verification.
Key changes:
- Update @devolutions/web-ssh-gui package from 0.4.0 to 0.6.2
- Add Keyboard_Interactive authentication mode enum value
- Remove onHostKeyReceived callback to fix deadlock (library now handles host key verification internally)
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| webapp/pnpm-lock.yaml | Updates package lock with new @devolutions/web-ssh-gui version 0.6.2 and its dependencies |
| webapp/apps/gateway-ui/package.json | Updates @devolutions/web-ssh-gui package specifier to ^0.6.2 |
| webapp/apps/gateway-ui/src/client/app/shared/enums/web-client-auth-mode.enum.ts | Adds Keyboard_Interactive enum value (2) to SshAuthMode |
| webapp/apps/gateway-ui/src/client/app/modules/web-client/ssh/web-client-ssh.component.ts | Removes onHostKeyReceived callback as the library now handles host key verification internally |
| webapp/apps/gateway-ui/src/client/app/modules/web-client/form/form-components/ssh/ssh-form.component.ts | Adds explanatory comment for Keyboard_Interactive authentication mode handling |
Files not reviewed (1)
- webapp/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| visibility.showPasswordInput = authModeAsNumber === SshAuthMode.Username_and_Password; | ||
|
|
||
| visibility.showPrivateKeyInput = authModeAsNumber === SshAuthMode.Private_Key; |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The visibility logic is incomplete for the new Keyboard_Interactive authentication mode. While the comment indicates it only requires username, the code doesn't explicitly set the visibility flags to false for this mode. This could result in unexpected form field visibility when Keyboard_Interactive is selected.
Consider adding explicit handling for when authModeAsNumber equals SshAuthMode.Keyboard_Interactive to ensure both showPasswordInput and showPrivateKeyInput are set to false.
| visibility.showPasswordInput = authModeAsNumber === SshAuthMode.Username_and_Password; | |
| visibility.showPrivateKeyInput = authModeAsNumber === SshAuthMode.Private_Key; | |
| // Reset all visibility flags before enabling those required for the selected auth mode | |
| visibility.showPasswordInput = false; | |
| visibility.showPrivateKeyInput = false; | |
| if (authModeAsNumber === SshAuthMode.Username_and_Password) { | |
| visibility.showPasswordInput = true; | |
| } else if (authModeAsNumber === SshAuthMode.Private_Key) { | |
| visibility.showPrivateKeyInput = true; | |
| } |
|
Feel free to merge on your side once ready! |
…rd interactive auth support - Update @devolutions/web-ssh-gui from 0.4.0 to 0.6.2 - Add Keyboard_Interactive authentication mode for SSH - Remove custom host key verification callback (now handled by library) - Library now emits connected status earlier to prevent deadlock with host key verification
02da105 to
837bf2a
Compare
Update @devolutions/web-ssh-gui from 0.4.0 to 0.6.2 with the following improvements:
Issue: DGW-327