-
Notifications
You must be signed in to change notification settings - Fork 24
fix(dgw): resolve sspi dependency conflict by updating IronRDP to 0.7 #1643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…API changes Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Run cargo format |
Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot See if you can use into_gcc_blocks() and remove the clone()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to use into_gcc_blocks() instead of gcc_blocks().clone() in commit a5effe3. This avoids the unnecessary clone by consuming the value.
Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Summary
Fixed the CI build failure caused by
sspi 0.16.1dependency conflict by updating IronRDP dependencies and adapting to API changes. Applied code formatting and optimized gcc_blocks handling to avoid unnecessary cloning.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.