Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 20, 2025

  • Investigate CI errors
  • Fix dependency conflicts
  • Update IronRDP dependencies to fix sspi 0.16.1 incompatibility
  • Adapt code to IronRDP API changes
  • Verify gateway builds successfully
  • Run cargo format
  • Use into_gcc_blocks() to avoid clone
  • Fix agent build (blocked by upstream IronRDP issue)

Summary

Fixed the CI build failure caused by sspi 0.16.1 dependency conflict by updating IronRDP dependencies and adapting to API changes. Applied code formatting and optimized gcc_blocks handling to avoid unnecessary cloning.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…API changes

Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 20, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/Devolutions/IronRDP/commits/master
    • Triggering command: /usr/bin/curl curl -s REDACTED known-linux-gnu/--tests tewa�� teway/devolution-D teway/devolutionwarnings bin/rustc teway/devolutiongit -incompat teway/devolution--exclude-standard bin/rustc tewa�� teway/devolutions-gateway/target/debug/build/awsINVALID,NEW teway/devolutions-gateway/target/debug/build/aws-j f/http-range-header-0.4.2/src/lib.rs aws_lc_0_35_0_crcargo teway/devolutionsearch teway/devolutionironrdp-pdu teway/devolution--limit (http block)
    • Triggering command: /usr/bin/curl curl -s REDACTED 64-REDACTED-linux-gnu/lib/libproc_macro-205600e30a99f188.rlib 64-u�� 64-REDACTED-linux-gnu/lib/librustc_std_workspace_std-31e31b7df4d72782.rlib ata_encoding-b9007e3f26681e73.rlib teway/devolution--json=diagnostic-rendered-ansi,artifacts,future-incompat teway/devolutiongit b2c7de9bd67e292.checkout b2c7de9bd67e292.copilot/sub-pr-1639 teway/devolution-C tewa�� teway/devolution-C teway/devolutiondebuginfo=2 .rlib /debug/deps/databash /debug/deps/data--norc /debug/deps/data--noprofile 141640.rlib (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add HTTP/SOCKS proxy configuration support fix(dgw): resolve sspi dependency conflict by updating IronRDP to 0.7 Dec 20, 2025
Copilot AI requested a review from CBenoit December 20, 2025 10:22
@CBenoit CBenoit marked this pull request as ready for review December 20, 2025 10:45
@CBenoit
Copy link
Member

CBenoit commented Dec 20, 2025

@copilot Run cargo format

Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 20, 2025

@copilot Run cargo format

Formatted the code with cargo +nightly fmt --all in commit a3d461f.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot See if you can use into_gcc_blocks() and remove the clone()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to use into_gcc_blocks() instead of gcc_blocks().clone() in commit a5effe3. This avoids the unnecessary clone by consuming the value.

Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
@CBenoit CBenoit merged commit df5c5c3 into DGW-328 Dec 20, 2025
22 of 26 checks passed
@CBenoit CBenoit deleted the copilot/sub-pr-1639 branch December 20, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants