v1.4.0 - 1.18.2 #19
Merged
v1.4.0 - 1.18.2 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working when skipping tests, unsure while failing on tests however
Contributor
Author
|
Also switches over to using |
Contributor
|
The tests always fail a certain percentage of the time. I never got around to fixing them, neither did anyone else to my memory. The builds on devoted skipped the tests, as they just were volumetric / probability tests, not functional. |
Contributor
|
Thank you for leaving this as a maven project. You might have forgotten a few things here or there but your changes are perfect, so no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working when skipping the tests, however completely unsure why tests are failing. Seems to be an import error from maven but my memory has forgotten a lot of it after working with gradle for the better part of the year
Includes PR #17 and PR #18