Skip to content

fix log level bug #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sclaw merged 1 commit into from
May 26, 2026
Merged

fix log level bug #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions hydroshift/app_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@
import sys
from pathlib import Path

NOISY_LOGGERS = {
"watchdog": logging.WARNING,
"PIL": logging.INFO,
"urllib3": logging.INFO,
"matplotlib": logging.WARNING,
"fiona": logging.WARNING,
"rasterio": logging.WARNING,
}
for logger_name, level in NOISY_LOGGERS.items():
logging.getLogger(logger_name).setLevel(level)

def handle_uncaught(exc_type, exc_value, exc_traceback):
if issubclass(exc_type, KeyboardInterrupt):
Expand All @@ -12,7 +22,7 @@ def handle_uncaught(exc_type, exc_value, exc_traceback):
logging.getLogger().critical("Uncaught exception", exc_info=(exc_type, exc_value, exc_traceback))


def setup_logging(log_dir: str = "logs", log_level: int = logging.INFO, log_file: str = "app.log") -> None:
def setup_logging(log_dir: str = "logs", console_level: int = logging.INFO, file_level: int = logging.DEBUG, log_file: str = "app.log") -> None:
# Make dir
Path(log_dir).mkdir(parents=True, exist_ok=True)
log_path = Path(log_dir) / log_file
Expand All @@ -23,17 +33,19 @@ def setup_logging(log_dir: str = "logs", log_level: int = logging.INFO, log_file

# Establish global settings
root_logger = logging.getLogger()
root_logger.setLevel(log_level)
root_logger.setLevel(logging.DEBUG)
if root_logger.hasHandlers():
root_logger.handlers.clear()

# Console handler
console_handler = logging.StreamHandler()
console_handler.setLevel(console_level)
console_handler.setFormatter(formatter)
root_logger.addHandler(console_handler)

# Rotating file handler
file_handler = logging.handlers.RotatingFileHandler(log_path, maxBytes=int(1e7), backupCount=5, encoding="utf-8")
file_handler.setLevel(file_level)
file_handler.setFormatter(formatter)
root_logger.addHandler(file_handler)

Expand Down
Loading