Add naming-semantics tests for URDF assembly; fix name_case propagation bug#203
Draft
Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
Draft
Add naming-semantics tests for URDF assembly; fix name_case propagation bug#203Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
Copilot wants to merge 2 commits intocjt/modify_urdf_assemblyfrom
Conversation
4 tasks
…_case propagation bug Co-authored-by: chase6305 <61959467+chase6305@users.noreply.github.com> Agent-Logs-Url: https://github.com/DexForce/EmbodiChain/sessions/005bec75-52f9-49bc-a9ff-5ff8cedd862b
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on URDF assembly component prefixes and name casing policy
Add naming-semantics tests for URDF assembly; fix name_case propagation bug
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
component_prefixpatching andname_casepolicy changes in the URDF assembly manager had no test coverage, and a bug causedname_caseupdates to never actually reachURDFComponentManager._name_case.Bug fix —
URDFComponentManagermissingname_caseproperty setterURDFAssemblyManager.name_casesetter calledself.component_manager.name_case = ..., butURDFComponentManagerhad no property setter, so Python silently created a dangling instance attribute while_name_caseremained unchanged. Added a proper getter/setter toURDFComponentManager:The new setter mirrors the constructor's lenient-validation strategy (warn + ignore invalid entries) and documents the intentional divergence from
URDFAssemblyManager.name_casewhich raisesValueError.New tests —
tests/toolkits/test_urdf_assembly_naming.py21 tests using minimal inline URDF fixtures across four focused test classes:
TestUnknownComponentKeyRaisesValueErrorTestComponentPrefixPreservesOrderTestNameCaseAffectsNamesupper/lower/nonemodes applied to link and joint names; setter validation; policy propagation toURDFComponentManagerTestSignatureChangesWithNamingSettingscomponent_prefixorname_caseproduces a distinct assembly signature (cache invalidation)⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.