Skip to content

Conversation

@ZohebShaikh
Copy link
Contributor

@ZohebShaikh ZohebShaikh commented Jan 5, 2026

The updated version of helm-values-schema resolves the issue with the required global variable, which is necessary when using the chart as a dependency. However, it introduces a new problem: references to #/defs/{model} (models within ApplicationConfig) are removed.
This appears to be caused by a bug in the RemoveUnusedDefs function. As a workaround, the schema generation has been updated to use $id references instead of defs. This change is safe in our case, as all models within ApplicationConfig are unique(will remain unique).

Closes #1192

@ZohebShaikh ZohebShaikh requested a review from a team as a code owner January 5, 2026 08:37
@ZohebShaikh ZohebShaikh changed the title Update helm-values-schema to v2.3.1 chore: update helm-values-schema to v2.3.1 Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.76%. Comparing base (b28250a) to head (20ccef4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   94.74%   94.76%   +0.01%     
==========================================
  Files          42       42              
  Lines        2741     2751      +10     
==========================================
+ Hits         2597     2607      +10     
  Misses        144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dan-fernandes dan-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZohebShaikh ZohebShaikh merged commit 1f829b0 into main Jan 6, 2026
18 checks passed
@ZohebShaikh ZohebShaikh deleted the update-helm-schema branch January 6, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update helm-schema-values-json plugin to at least v2.3.0

3 participants