-
Notifications
You must be signed in to change notification settings - Fork 11
Remove manual AutoProcScalingStatistics declaration #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 92.20% 92.20% -0.01%
==========================================
Files 27 27
Lines 4144 4143 -1
Branches 166 166
==========================================
- Hits 3821 3820 -1
Misses 230 230
Partials 93 93 🚀 New features to boost your workflow:
|
|
Do the other relationship declarations here have the same issue? |
I didn't expect them to, since they had different names and my local tests didn't fail, at least until Jake mentioned it. I've now replaced the other declarations with synonyms
Agreed, this might only happen again with new SQLAlchemy versions (in the distant future), but this is a good idea |
|
You happy to merge or did you want to check anything else? |
Happy to merge it, I'll do it now |
Since this is already being declared as an autogenerated ORM model, we do not need to declare it again. Doing so triggers a deprecation warning, and may cause undefined behaviour in future versions of SQLAlchemy.
This fixes #233