Add sampleimage positioners #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlLevik
requested changes
Aug 11, 2022
Member
KarlLevik
left a comment
KarlLevik
left a comment
There was a problem hiding this comment.
Could do with a table comment to explain what the table is for.
RESTRICT is the default for both ON DELETE and ON UPDATE. This is what you want for both FKs?
KarlLevik
requested changes
Aug 17, 2022
Member
KarlLevik
left a comment
KarlLevik
left a comment
There was a problem hiding this comment.
I don't think there is much of a case for charset + collation as utf8mb4 on this table. Would prefer if it just used the database default. Also not sure we should specify the storage engine. We do of course specify it in the tables.sql, but maybe that is a mistake. It makes it harder to migrate to another storage engine, or for a facility to choose a different storage engine should they wish to do that. InnoDB is the default anyway.
stufisher
force-pushed
the
sampleimage_positioner
branch
from
c1e0a3a to
2869ee9
Compare
KarlLevik
approved these changes
Aug 17, 2022
stufisher
force-pushed
the
sampleimage_positioner
branch
from
2869ee9 to
f52e881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to store one or more
Positioners with aBLSampleImage, primary to define the z motor position so that rois/pois can be bought back into focus from a sample image where there is no online axis camera.This table will work both with and without #105 (i'm not ready to deploy the changes in #105 yet at ESRF)