Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ SciReactUI Changelog

### Fixed
- Hovering over a slot caused a popup with the slot title in. This has been removed.
- Stopped Bar-based components (e.g. Navbar, Footer) from expanding when a parent component has a set height

### Changed
- Remove first-child css selector as it causes problems with server-side rendering.
Expand Down
2 changes: 1 addition & 1 deletion src/components/controls/Bar.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe("Bar", () => {
// check new style is set
expect(headerComputedStyle.border).toBe(borderStyle);
// Check default values are still set
expect(headerComputedStyle.height).toBe("100%");
expect(headerComputedStyle.height).toBe("auto");
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/components/controls/Bar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const Slot = ({ className, style, children }: SlotProps) => (

const BoxStyled = styled(Box)<BoxProps>(({ theme }) => ({
width: "100%",
height: "100%",
height: "auto",
minHeight: "50px",
display: "flex",
alignItems: "center",
Expand Down
2 changes: 1 addition & 1 deletion src/components/navigation/Navbar.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe("Navbar", () => {
expect(headerComputedStyle.border).toBe(borderStyle);

// Check default values are still set
expect(headerComputedStyle.height).toBe("100%");
expect(headerComputedStyle.height).toBe("auto");
});
});

Expand Down