Seperated dataclasses in datatypes from guibuilder #15
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
It's not installing the entrypoint, I'll try to fix the actons |
src/phoebus_guibuilder/guibuilder.py
Outdated
| """ | ||
|
|
||
| def __init__(self, create_gui: str): |
There was a problem hiding this comment.
It might be better to name the file arg something like "create_gui_file" or "create_gui_yaml" just to clarify it is the file.
There was a problem hiding this comment.
Will make create_gui_yaml, I think that suits it? Probably need to add some error reporting for bad yaml files, and wrong file types in general
| to the required screen in gui_map.yaml | ||
| """ | ||
|
|
||
| gui_map = "/BLGui/BLGuiApp/opi/bob/gui_map.yaml" |
There was a problem hiding this comment.
Is the plan to still try and have BLGui as a submodule to this repo? If so, will this path be the same?
There was a problem hiding this comment.
No, will make changes in a further PR to resolve it. But BLGui is internal, and a diamond thing. So it's basically warded off by gitlab token access, and will only be available to diamond users, hard coding the path seems reasonable??? - I also assume we won't clone a version of it in every beamline services folder? If so, it's between relative path to the services folder, or the beamline submodule folder.
There was a problem hiding this comment.
Is it worth discussing with Tom about moving it to Github then? Would make our lives so much easier...
There was a problem hiding this comment.
Yes, I'll make the request now
src/phoebus_guibuilder/guibuilder.py
Outdated
| print("No BOB available") | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
we shouldn't need these two lines seeing as the command line should be handled by __main__.py; this script shouldn't need to be manually run.
OCopping
force-pushed
the
PhoebusGuiBuilderClass
branch
from
63aa88a to
0f41daf
Compare
Rebasing phoebus class redesign with changes made to testing and dependencies.
OCopping
force-pushed
the
PhoebusGuiBuilderClass
branch
from
0f41daf to
262fd6e
Compare
Seperated guibuilder functional class and dataclasses