feat(charts): deterministic postgres secrets, sealed in host cluster #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davehadley
force-pushed
the
drh/stable-database-passwords
branch
4 times, most recently
from
98e333a to
bc9dd3b
Compare
davehadley
force-pushed
the
drh/stable-database-passwords
branch
from
bc9dd3b to
322c995
Compare
davehadley
requested review from
JamesDoingStuff,
VictoriaBeilsten-Edmands and
iamvigneshwars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, postgres secrets are randomized at helm install time. This is secure, however, can lead to problems recovering in cases where the cluster experiences unplanned down time. For example, see the incident report at:
https://dlsltd.sharepoint.com/:w:/s/Workflows/IQAeKijFhDqOT4adurvgibS4AVgjeK0bgzZstcE1tmf5T-A?e=3l6NGx
This PR replaces the randomized passwords with static SealedSecrets.