Implement responsive design for main pages and fix CSS errors#2
Implement responsive design for main pages and fix CSS errors#2DiegoDev-7 wants to merge 1 commit into
Conversation
…f the contacts application and fix for some CSS errors
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa35a2f5a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {trash && ( | ||
| <button |
There was a problem hiding this comment.
The delete control is gated by a single component-wide trash flag, so hovering any one contact makes all rows render their delete button ({trash && ...}). In a multi-contact list this exposes destructive actions on non-hovered rows and makes accidental deletion much more likely; this should be keyed to the active contact_id (or row-local hover state) so only the intended row becomes deletable.
Useful? React with 👍 / 👎.
| position: absolute; | ||
| right: 35px; | ||
| transform: translateY(22.5px); |
There was a problem hiding this comment.
.box-delete-contact is absolutely positioned, but its parent row (.contact-item) is not positioned, so each delete button is placed relative to the page/container rather than its own item. With multiple contacts, delete buttons stack at the same coordinates and the topmost one can correspond to a different contact than the row the user is interacting with, causing wrong-contact deletions.
Useful? React with 👍 / 👎.
DiegoDev-7
force-pushed
the
main
branch
3 times, most recently
from
0d46302 to
9f19d4f
Compare
1 participant
Trial phase merge to main with Nexia launch