fix(#190): rename internal _settle params to avoid shadowing#245
Merged
dDevAhmed merged 1 commit intoJun 30, 2026
Merged
Conversation
Rename `beneficiary`/`amount` parameters of the internal `_settle` function to `_beneficiary`/`_amount` using the underscore-prefix convention. This removes any potential shadowing of inherited declarations and improves readability/audit clarity. - Behavior, ABI, and storage layout are unchanged. - Call sites in `settleClaim` and `settleClaimsBatch` are unaffected (positional). - Added unit test asserting single and batch paths emit correct ClaimSettled args. - References: Internal Ref CO-190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the internal
_settlefunction parameters frombeneficiary/amountto_beneficiary/_amount(underscore-prefix convention) to eliminate any potential shadowing of inherited declarations flagged during audit.Changes
_settleparams and updated internal references. Call sites (settleClaim,settleClaimsBatch) untouched — args are positional.ClaimSettledargs and balances after the rename.Why
_settle.Acceptance Criteria
ClaimSettledargs)Security / Integrity
Risk
References
feat/audit-190-shadowing-settlecloses #190