add custom actions support#2234
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9bafdf895
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| icon = UiIcon.More, | ||
| text = ActionMenu.Item.Text.Localized(ActionMenu.Item.Text.Localized.Type.More), | ||
| ), | ||
| actions = normalizedOverflow.toPersistentList(), |
There was a problem hiding this comment.
When a user moves Repost to the More menu, normalizedOverflow can contain the original repost ActionMenu.Group, and this line nests that group inside the generated More group. The Compose renderer explicitly ignores nested groups (CommonStatusComponent.kt:943-945), so the Repost/Quote actions disappear instead of moving into overflow. Flatten grouped post actions or render nested groups before placing them in the generated More menu.
Useful? React with 👍 / 👎.
| val displayItems = | ||
| remember(items, appearanceSettings.postActionLayout) { | ||
| items.applyPostActionLayout(appearanceSettings.postActionLayout) | ||
| } |
There was a problem hiding this comment.
When custom post action layout is enabled, this rewrites every caller of StatusActions, but ProfileMenu also passes profileState.actions here. Those profile actions are a MoreVerticel group with no PostActionFamily, so the layout helper treats the whole profile menu as unknown overflow and wraps it in a generated More group; because nested groups are ignored by the Compose menu renderer, the profile toolbar actions such as mute/block/report disappear. Restrict this layout pass to post rows or add an opt-out for non-post action menus.
Useful? React with 👍 / 👎.
1 participant
No description provided.