Feature/dependency update#2235
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96f927dedb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| options: | ||
| minimumXcodeGenVersion: 2.45.4 | ||
| xcodeVersion: "26.0" |
There was a problem hiding this comment.
When CI or developers generate Flare.xcodeproj from this spec, XcodeGen does not preserve Icon Composer .icon bundles unless options.fileTypes."icon".file: true is set; the upstream XcodeGen issue notes that by default it treats the bundle contents as individual resources and “breaks Xcode's recognition” of the icon. This repo's only primary app icon is iosApp/flare/AppIcon.icon with no primary AppIcon.appiconset, so the generated project will add icon.json/layer files instead of AppIcon.icon, and Xcode won't recognize AppIcon as the app icon for generated iOS builds. Add the file type override under options.
Useful? React with 👍 / 👎.
1 participant
No description provided.