Skip to content

fix ios agent input#2238

Merged
Tlaster merged 2 commits into
masterfrom
bugfix/ios-agent-input
Jun 19, 2026
Merged

fix ios agent input#2238
Tlaster merged 2 commits into
masterfrom
bugfix/ios-agent-input

Conversation

@Tlaster

@Tlaster Tlaster commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8d19fc39d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 96 to 98
.onChange(of: draft) { _, value in
onInputChange(value)
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the draft synced with presenter input

When the presenter changes input without a local TextField edit, the iOS draft now stays stale because this is the only remaining binding path. AgentChatPresenterController.selectInputRequestOption can programmatically set input for non-submitting options and clears it for submitting options, so tapping an agent-provided option can leave the visible field different from the presenter state: users may see old text while Send is disabled, or send hidden prefilled text that never appeared in the field. Please preserve a presenter-to-draft sync path while avoiding the original reset issue.

Useful? React with 👍 / 👎.

@Tlaster Tlaster merged commit 52facec into master Jun 19, 2026
9 checks passed
@Tlaster Tlaster deleted the bugfix/ios-agent-input branch June 19, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant