Feature/fanbox#2242
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a7ec4da8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ErrorContent( | ||
| error = error, | ||
| onRetry = state::refresh, | ||
| onRetry = {}, |
There was a problem hiding this comment.
When the gallery detail load fails on Android, for example after a transient network or auth error, the retry button rendered by ErrorContent now invokes an empty lambda, so tapping it cannot re-request the detail and the user has to leave and reopen the screen. This replaced the previous state.refresh path, and the same no-op retry was added on desktop as well.
Useful? React with 👍 / 👎.
| val bookmarked = bookmarkText?.type == ActionMenu.Item.Text.Localized.Type.Unbookmark | ||
| val bookmarkCount = bookmarkAction?.count?.value ?: 0L | ||
| GalleryDetail( | ||
| orientation = GalleryOrientation.Vertical, |
There was a problem hiding this comment.
For landscape Pixiv illustrations, this hardcoded Vertical orientation forces the new gallery screens down the stacked vertical-image path even though they still branch on detail.orientation to choose the horizontal pager layout. The previous Pixiv detail mapper selected Horizontal when the illustration width was at least its height, so wide Pixiv artwork now opens in the wrong layout.
Useful? React with 👍 / 👎.
1 participant
No description provided.