feat(composer): persist Codex params per thread #380

Samigos · 2026-02-09T18:39:07Z

Persist model, effort, access mode, and collaboration mode selections per thread in localStorage.

Dimillian · 2026-02-09T19:33:37Z

hmmmmmmm but a new thread take which default?

Dimillian · 2026-02-09T19:33:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85b7f1d112

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-09T19:37:13Z

src/features/collaboration/hooks/useCollaborationModes.ts

+  useEffect(() => {
+    if (!enabled) {
+      return;
+    }
+    if (selectionKey === lastSelectionKey.current) {
+      return;
+    }
+    lastSelectionKey.current = selectionKey;
+    setSelectedModeId(preferredModeId);


Preserve a valid collaboration mode on thread switch

When the per-thread selectionKey changes, this effect unconditionally replaces the current selection with preferredModeId (which is null for threads without stored overrides), so switching to such a thread clears selectedCollaborationModeId even though the mode list is already loaded and a default is available. Because no refetch runs on thread change, the selection stays null, which in turn makes useCollaborationModeSelection produce a null payload and drops collaboration-mode settings for those threads. Consider keeping the existing selection or falling back to the computed default when preferredModeId is null or not present in modes.

Useful? React with 👍 / 👎.

Samigos · 2026-02-09T20:00:08Z

hmmmmmmm but a new thread take which default?

It seems it uses no plan-mode, last used codex model, last used effort and on-request access mode.

Dimillian · 2026-02-09T20:00:56Z

hmmmm not sure we wants that

Samigos · 2026-02-09T20:03:46Z

Ok, what do you think would be best?

To me, the problem is that every time I change an agent, I carry the last parameters and it can be confusing if I'm working on multiple at the same time.

Dimillian · 2026-02-09T20:31:57Z

Hmmmm I think we should have those param in the main app settings (I think we already do, but partially?)
Maybe make a new entry in there, where youc an set the default for those settings (and so move the access one from the Codex section), so there you can set your default that will be used for each new thread.

Samigos · 2026-02-09T20:45:24Z

Hmmmm I think we should have those param in the main app settings (I think we already do, but partially?) Maybe make a new entry in there, where youc an set the default for those settings (and so move the access one from the Codex section), so there you can set your default that will be used for each new thread.

To clarify, when you say main app settings, which tab do you mean?

Dimillian · 2026-02-10T05:57:21Z

Not sure where it fit best or if we need a new section 😆

Samigos · 2026-02-10T11:06:06Z

Ok, I think it works great now, but I'd appreciate it if someone does some testing, just to make sure!
Also, @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0281deb78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-10T11:16:03Z

src/features/collaboration/hooks/useCollaborationModes.ts

+      return;
+    }
+    lastSelectionKey.current = selectionKey;
+    setSelectedModeId(preferredModeId);


Preserve a valid collaboration mode on thread switches

When selectionKey changes, this effect unconditionally assigns preferredModeId (which is null for threads without a stored override in App.tsx) to selectedModeId. In that common case, the hook clears the existing/default mode, and because lastFetchedWorkspaceId is already set for the workspace, no refetch runs to restore a default selection; subsequent sends from that thread omit collaborationMode until the user manually reselects one.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3f3b9bf2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/App.tsx

src/features/collaboration/hooks/useCollaborationModes.ts

… modes Branch summary (Codex params + settings + collaboration modes) Settings -> Codex - Added a 'Default parameters' section that lets users pick default model, reasoning effort, and access mode. - Model options are aggregated from connected workspaces via getModelList(), de-duped by slug, and sorted by a 'latest' heuristic. - Reasoning effort options are derived from the selected model's supportedReasoningEfforts (lowercased) and default to 'medium'. - Removed any explicit 'default' option from model/effort pickers; the section context is the default. - Styled these controls like other settings cards. Thread-scoped Codex params - Persist per-thread overrides for model/effort/collaboration/access. - Keep per-thread changes from mutating the global defaults; global defaults only change in the no-thread composer. - Seed newly created threads once (avoid post-send flips) so model/effort/collab/access remain stable after the first message. Collaboration modes - On thread switch, prefer the thread override; otherwise reset to the workspace default so plan/code selections don't bleed across threads. - When sending the first message from the no-thread composer, snapshot collaboration mode and access mode and apply them to the created thread. - Validate preferredModeId on selectionKey changes: if a stored override is stale (mode removed/renamed), fall back to the workspace default instead of disabling collaboration payloads. Tests - Added a regression test for stale preferredModeId fallback in useCollaborationModes.

# Conflicts: # src/App.tsx

Samigos · 2026-02-10T18:31:01Z

@Dimillian I was about to fix the conflicts! We good?

Dimillian · 2026-02-10T18:31:46Z

@Dimillian I was about to fix the conflicts! We good?

Yes finishing touches

feat(composer): persist Codex params per thread

85b7f1d

Persist model, effort, access mode, and collaboration mode selections per thread in localStorage.

chatgpt-codex-connector bot reviewed Feb 9, 2026

View reviewed changes

feat(settings): set Codex default model and effort

91aa578

feat(settings): Codex default params UI + thread seeding

c0281de

Merge branch 'main' into codex-parameters-per-agent

a022527

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

Samigos added 3 commits February 10, 2026 13:38

fix(composer): keep model/effort thread-scoped

1bc8309

fix(collab): preserve mode on thread switch

d569928

fix(collaboration): seed new thread with composer collab mode

f3f3b9b

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

src/App.tsx Outdated Show resolved Hide resolved

src/features/collaboration/hooks/useCollaborationModes.ts Outdated Show resolved Hide resolved

Samigos and others added 2 commits February 10, 2026 18:26

Merge branch 'main' into pr/380

38a5e31

# Conflicts: # src/App.tsx

Dimillian added 3 commits February 10, 2026 20:25

Cleanup

56c5b9e

refactor: extract codex seed/model parsing helpers and tests

c3bc082

fix: reset mode selection and ignore stale default model results

f442d1f

Dimillian merged commit 15eccee into Dimillian:main Feb 10, 2026
6 checks passed

Uh oh!

feat(composer): persist Codex params per thread #380

feat(composer): persist Codex params per thread #380

Uh oh!

Conversation

Samigos commented Feb 9, 2026

Uh oh!

Dimillian commented Feb 9, 2026

Uh oh!

Dimillian commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Samigos commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dimillian commented Feb 9, 2026

Uh oh!

Samigos commented Feb 9, 2026

Uh oh!

Dimillian commented Feb 9, 2026

Uh oh!

Samigos commented Feb 9, 2026

Uh oh!

Dimillian commented Feb 10, 2026

Uh oh!

Samigos commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Samigos Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Samigos Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Samigos commented Feb 10, 2026

Uh oh!

Dimillian commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Samigos commented Feb 9, 2026 •

edited

Loading