Fix concurrency related build issues#11
Open
SynergyMike wants to merge 6 commits intoDimillian:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to use Xcode 26 beta in CI workflows, adjusts platform deployment targets for macOS, and improves test reliability and actor-safety in the test suite. The most important changes are grouped below:
CI/CD Workflow Updates:
.github/workflows/icy_sky.ymlto use Xcode 26 beta instead of Xcode 16.1, ensuring builds and tests run against the latest Xcode version. [1] [2] [3]Platform Deployment Target Adjustments:
.v26to.v15in bothPackages/Features/Package.swiftandPackages/Model/Package.swift, increasing compatibility. [1] [2]Test Improvements and Actor Safety:
UpdatesCollectoractor inAuthTests.swiftto safely collect asynchronous updates, and refactored tests to use this actor for concurrency correctness. [1] [2] [3]@MainActorannotations to test structs and view builders inHeaderViewTests.swift,FeedsListTitleViewTests.swift, andAppTabsRoot.swiftto ensure UI-related code runs on the main thread. [1] [2] [3]