[codex] feat: add breadcrumb navigation trail#604
Open
shinzoxD wants to merge 2 commits into
Open
Conversation
Author
|
Small improvement pushed in commit
Previously, only the current (last) breadcrumb segment had a Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breadcrumbcomponent withnav+ ordered-list semantics.aria-current=pageand keep it non-linking.truncateMiddlehelper.VaultDetail,VaultTransactions, andValidationDetail.Closes #454
Validation
.\node_modules\.bin\vitest.cmd run src/components/__tests__/Breadcrumb.test.tsx --environment jsdom --coverage=false.\node_modules\.bin\tsc.cmd -b --pretty falsestops on unrelated syntax/conflict-marker errors inConfirmationModal.tsx,PendingValidations.tsx,PendingValidations.test.tsx, andcsv.analytics.test.ts.npm testran for 120s and hit existing failures such as undefinedcreateMilestoneRowinCreateVaultand undefinedShortcutsHelpinLayout.VaultDetail.test.tsxstill fails on undefinedisValidinAddressDisplayand undefinedmockDownloadIcsEventin the test file.