Skip to content

test: cover ThemeContext system-preference change listener #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Truphile wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: cover ThemeContext system-preference change listener #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
467d7e8
test: cover ThemeContext system-preference change listener
Truphile Jun 29, 2026
543e612
theme commit
Truphile Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 143 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 18 additions & 2 deletions src/context/__tests__/ThemeContext.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ describe('ThemeContext safe storage', () => {
vi.spyOn(window, 'matchMedia').mockImplementation((query: string) => ({
matches: false,
media: query,
addEventListener: jest.fn(),
removeEventListener: jest.fn(),
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
} as unknown as MediaQueryList));
vi.spyOn(Storage.prototype, 'getItem');
vi.spyOn(Storage.prototype, 'setItem');
Expand Down Expand Up @@ -312,4 +312,20 @@ describe('ThemeContext OS preference following', () => {
fireOsDarkChange(false);
expect(screen.getByTestId('theme')).toHaveTextContent('light');
});

test('removes listener on unmount', () => {
const { unmount } = render(
<ThemeProvider>
<TestComponent />
</ThemeProvider>
);

// The listener should be added on mount
expect(mediaEventHandlers.has('(prefers-color-scheme: dark)')).toBe(true);

unmount();

// The listener should be removed on unmount
expect(mediaEventHandlers.has('(prefers-color-scheme: dark)')).toBe(false);
});
});