Skip to content

ENG-739 Move color selector from Canvas to General tab#945

Open
trangdoan982 wants to merge 8 commits intomainfrom
worktree-eng-739-move-color-selector-from-canvas-to-general-tab
Open

ENG-739 Move color selector from Canvas to General tab#945
trangdoan982 wants to merge 8 commits intomainfrom
worktree-eng-739-move-color-selector-from-canvas-to-general-tab

Conversation

@trangdoan982
Copy link
Copy Markdown
Member

@trangdoan982 trangdoan982 commented Apr 7, 2026

Summary

  • Moves the color picker from the Canvas tab to the General tab in node type settings
  • Tag now also has previewed color
Screenshot 2026-04-08 at 15 25 02

After changing setting, node tag and node menu reflects the changes fron General tab
Screenshot 2026-04-08 at 15 25 25

Canvas no longer has color picker
Screenshot 2026-04-08 at 15 24 37

Closes ENG-739

🤖 Generated with Claude Code


Open with Devin

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@linear
Copy link
Copy Markdown

linear bot commented Apr 7, 2026

@supabase
Copy link
Copy Markdown

supabase bot commented Apr 7, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@trangdoan982 trangdoan982 requested a review from mdroidian April 8, 2026 19:26
Copy link
Copy Markdown
Member

@mdroidian mdroidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blocking change here is the Tooltip and text color of tag, but let's do all 4.

Comment thread apps/roam/src/components/settings/NodeConfig.tsx Outdated
Comment thread apps/roam/src/components/settings/NodeConfig.tsx Outdated
Comment thread apps/roam/src/components/settings/NodeConfig.tsx Outdated
Comment thread apps/roam/src/components/settings/NodeConfig.tsx Outdated
@trangdoan982 trangdoan982 requested a review from mdroidian April 15, 2026 18:27
Copy link
Copy Markdown
Member

@mdroidian mdroidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI is failing

@trangdoan982
Copy link
Copy Markdown
Member Author

@mdroidian I think this might be CI error. I don't see any type and lint error on my local. I tried running npx turbo check-types and all tests passed. The error on the NodeConfig.tsx file is also absent on my local. I also don't think it should error there because I simply moved that code from Canvas setting to NodeConfig.

graphite-app[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Member

@mdroidian mdroidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the requested changes and see if the CI error remains.

Comment thread apps/roam/src/components/settings/NodeConfig.tsx Outdated
@trangdoan982 trangdoan982 requested a review from mdroidian April 15, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants