Port server tests to PHPUnit 12 mock API#115
Merged
Merged
Conversation
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.5.55 to 12.5.22. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/12.5.22/ChangeLog-12.5.md) - [Commits](sebastianbergmann/phpunit@11.5.55...12.5.22) --- updated-dependencies: - dependency-name: phpunit/phpunit dependency-version: 12.5.22 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
PHPUnit 12 removed MockBuilder::addMethods(); Predis\Client dispatches commands via __call() so reflection can't see them for onlyMethods(). Add a test-only stub class exposing the commands we mock as concrete no-ops, then mock the stub with onlyMethods() throughout the suite. Also convert CreateRequestTest @dataProvider annotations to the #[DataProvider] attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MockBuilder::addMethods(), which the server suite used heavily to mockPredis\Clientcommands (dispatched via__call(), so invisible to reflection).tests/Support/RedisClientStub.php— a subclass ofPredis\Clientexposing the mocked commands as concrete no-ops soonlyMethods()can override them.onlyMethods().CreateRequestTest@dataProviderdocblocks to#[DataProvider]attributes (annotation metadata removed in PHPUnit 12).Closes #113.
Test plan
composer installresolves PHPUnit 12.5.22vendor/bin/phpunit— 189 tests, 0 errors, 0 failures (local run in php:8.4-cli)testjob passes on this PR