Move javascript for credit checkboxes to the js file #1372
Conversation
| echo "<input type='checkbox' name='cp_credit' value='yes' $cp_credit_checked> CP\n"; | ||
| echo "<input type='checkbox' name='ip_credit' value='yes' $ip_credit_checked> IP\n"; | ||
| echo "<input type='checkbox' name='tp_credit' value='yes' $tp_credit_checked> TP\n"; | ||
| echo "<input type='checkbox' name='cp_credit' class='credit_box' value='yes' $cp_credit_checked> CP\n"; |
There was a problem hiding this comment.
minor suggestion, but instead of adding a class to every checkbox, maybe just tag the table cell and then query all inputs under that cell?
tableCell.querySelectorAll('input[type=checkbox]')
There was a problem hiding this comment.
Good idea. I'll look into it.
There was a problem hiding this comment.
Is @chrismiceli's suggestion still being considered?
There was a problem hiding this comment.
Thanks for reminding me. @chrismiceli's suggestion would make it more compact but looking at structure of userprefs.php, the function _show_credits_wanted_adhoc() is far removed from the table structure so I think it makes it clearer how it is intended to work to leave it like it is. (Leaving aside the unusual way the show_ functions are called, see comment on line 874).
4 participants
Sandbox at: https://www.pgdp.org/~rp31/c.branch/userpref_js