Remove unnecessary page_controls.inc usage #1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70ray
approved these changes
Dec 24, 2025
chrismiceli
approved these changes
Dec 24, 2025
srjfoo
approved these changes
Dec 26, 2025
Member
srjfoo
left a comment
srjfoo
left a comment
There was a problem hiding this comment.
Ran into some weird stuff in the console in FF, but neither Chrome not Safari showed any problems at all. I've determined to my satisfaction that the FF complaints have nothing to do with the test server or this branch, so, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on cleaning up the new PI branch I discovered that we use
page_controls.inchere but we don't need to. We only needget_proofreading_interface_data_js()if we're using the text pane of the Page Browser, but the context windows only show the image.Testing will be confirming that the WordCheck PM tools, like showing the context of a proofreader suggestion, all still work and there are no errors on the browser console.
Sandbox: https://www.pgdp.org/~cpeel/c.branch/remove-extraneous-page-controls