Fix reindex bug if 2 anchors per footnote #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug occurred because it changed the number in the footnote for every anchor. So if there were two anchors, it changed the number in the footnote twice. However, the change was based on character positions, so if the number was "26", it replaced those two characters with "XXVI.", for example, then when it did the second replacement, it replaced two of those characters with "XXVI." leading to something like "XXVI.VI." Fixes DistributedProofreaders#1595
srjfoo
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug occurred because it changed the number in the footnote for every anchor. So if there were two anchors, it changed the number in the footnote twice. However, the change was based on character positions, so if the number was "26", it replaced those two characters with "XXVI.", for example, then when it did the second replacement, it replaced two of those characters with "XXVI." leading to something like "XXVI.VI."
Fixes #1595