Skip to content

Conversation

@tibisabau
Copy link

@tibisabau tibisabau commented Dec 5, 2025

Summary

PR for issue #344. The summary below the title has been deleted and moved to the respective chart headers. Closes #344

The Code was generated using GitHub Copilot.

Pull Request Checklist

Put an x in the boxes that apply.

  • Tests passed.
      python manage.py test tests/ --noinput
  • No testing required.
  • Make sure you are requesting to pull a topic/feature/bugfix branch. Don't request your master!
  • A descriptive title and description of the changes made are provided.
  • Submit one item per pull request. This eases reviewing and speeds up merging.
  • All changed files cannot be split into multiple pull requests (must be in one PR)
  • The documentation is up-to-date

When applicable

  • The issue number is provided in the description or title of the pull request.
  • Does this close the issue mentioned?
  • Screenshots of the results are provided.
  • Additional tests have been written.

Copilot AI review requested due to automatic review settings December 5, 2025 19:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR redesigns the conversion summary report by moving summary statistics from a separate section below the title into the chart headers themselves. The change improves the visual layout by consolidating related information directly with each chart rather than displaying it separately at the top.

  • Removed the summary loop from the template that previously displayed statistics as a list
  • Added summary statistics directly to chart titles using HTML line breaks
  • Updated chart titles to include both conversion percentages and total request counts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
analytics/templates/analytics/summary_change_list.html Removed the loop that displayed summary statistics separately, now that this information is shown in chart headers
analytics/site/conversionadmin.py Added mark_safe imports and updated chart titles to include summary statistics with HTML formatting (line breaks)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tibisabau and others added 3 commits December 5, 2025 20:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversion Summary report Redesign

1 participant