fix: contain scroll chaining inside menu lists (Doist/Issues#20168)#1036
Closed
doistbot wants to merge 1 commit into
Closed
fix: contain scroll chaining inside menu lists (Doist/Issues#20168)#1036doistbot wants to merge 1 commit into
doistbot wants to merge 1 commit into
Conversation
Automated fix generated by Doistbot based on triage analysis. Issue: #20168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Doist/Issues/issues/20168
Short description
Add overscroll containment to the shared
MenuListscroll container so tall menus keep wheel scrolling inside the menu instead of passing it through to scrollable surfaces behind the portal-rendered menu. This gives the calendar task context menu the containment it was missing without changing Todoist-specific code.