Issue 221 aec architecture objects #969
Conversation
# Conflicts: # src/ACadSharp/DxfSubclassMarker.cs # src/ACadSharp/IO/DWG/DwgStreamReaders/DwgObjectReader.cs
DomCR
changed the base branch from
issue-221-aec-architecture-objects
to
master
| /// </summary> | ||
| public XYZ EndPoint { get; set; } = XYZ.Zero; | ||
| public XYZ Normal { get; internal set; } | ||
| public double Height { get; internal set; } |
There was a problem hiding this comment.
Normal and Height should be able to be modified by the user, the internal can be removed.
We can leave it for the other properties like style by now and come back later.
|
|
||
| this.readCommonNonEntityData(template); | ||
|
|
||
| try |
There was a problem hiding this comment.
This try is not needed, the Read() method already has the failsafe in place.
| /// Object name: AEC_CLEANUP_GROUP | ||
| /// </remarks> | ||
| [DxfName("AEC_CLEANUP_GROUP")] | ||
| [DxfSubClass("AecDbCleanupGroup")] |
There was a problem hiding this comment.
Instead of using literals, the 2 attributes should use DxfFileToken and DxfSubclassMarker.
Same for AecWallStyle.
|
Great job with this one 👌! This may be the start to use the AEC Objects. |
|
General review notes:
|
|
I tried analyzing these remaining bytes for their content. Currently it is not usable without having wall positions, width or any other meaningful property. |
|
For the writers, remember to add the new objects to the following methods:
Thanks! |
2 participants
Description
Two years later I tried again.
Created basic structure.
Found handles to wallStyle and cleanupGroup.
BinRecord handle not found.
Tried analyzing BinRecord but no success so far. Unsure if this is related at all.
Tasks done in this PR
Related Issues / Pull Requests
#221
Notes for reviewer