-
Notifications
You must be signed in to change notification settings - Fork 302
Update smtpkit.com.domain-auth.json #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Linter OK: |
xindex2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Changed the SPF record from bare TXT type to SPFM type with spfRules
Bumped version from 1 to 2
xindex2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped version from 1 to 2
add Smtpkit : MX & SPF records
xindex2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating SPF & MX
| "variableDescription": "The variable %smtpkit_code% represents a combination of prefix string and a MD5 hash. %dkim_selector% and %dkim_selector2% is the DKIM selector for placing the DKIM public key. This needs to be a variable because the selector is dynamically generated. %dkim_public_key% is the DKIM public key. %dmarc_value% is dmarc value.", | ||
| "warnPhishing": true, | ||
| "hostRequired": false, | ||
| "multiInstance": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Boolean values that use false can be omitted, as json defaults to false.
kerolasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
<-- short description of the template(s) and/or reason for update -->
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverExample variable values
<-- to make review process easier please provide example set of variable values for this template -->
<-- Example: -->
<-- Or provide the whole
testDataobject from the Online Editor after testing and using "Add as test" button -->