Skip to content

Conversation

@xindex2
Copy link

@xindex2 xindex2 commented Dec 26, 2025

Description

<-- short description of the template(s) and/or reason for update -->

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->

<-- Example: -->

var1: aaa
var2: foo.com

<-- Or provide the whole testData object from the Online Editor after testing and using "Add as test" button -->

"testData": {
    "testset": {
      "variables": {
        "domain": "example.com",
        "host": "foo",
        "example": "bar"
      },
      "results": [
        {
          "type": "TXT",
          "name": "foo",
          "ttl": 86400,
          "data": "\"bar\""
        }
      ]
    }
  }

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

Linter OK:

Linter result for smtpkit.com.domain-auth.json

Copy link
Author

@xindex2 xindex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Changed the SPF record from bare TXT type to SPFM type with spfRules

Bumped version from 1 to 2
Copy link
Author

@xindex2 xindex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped version from 1 to 2

add Smtpkit : MX & SPF records
Copy link
Author

@xindex2 xindex2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating SPF & MX

@kerolasa kerolasa self-requested a review January 5, 2026 09:53
"variableDescription": "The variable %smtpkit_code% represents a combination of prefix string and a MD5 hash. %dkim_selector% and %dkim_selector2% is the DKIM selector for placing the DKIM public key. This needs to be a variable because the selector is dynamically generated. %dkim_public_key% is the DKIM public key. %dmarc_value% is dmarc value.",
"warnPhishing": true,
"hostRequired": false,
"multiInstance": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Boolean values that use false can be omitted, as json defaults to false.

Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants