Skip to content

Conversation

@speige
Copy link
Contributor

@speige speige commented Dec 8, 2024

Make SylkParser more robust to handle malformed files & ignore useless tags, like formatting.

@Drake53
Copy link
Owner

Drake53 commented Dec 19, 2024

Do you have example .slk files which use these tags? I know the implementation is incomplete because I only intended to load the .slk files from wc3, which only use the ID, B, C, and E tags.

@speige
Copy link
Contributor Author

speige commented Dec 19, 2024

SLK Files.zip
These are all files that are part of the base game extracted from the casc. They fail with the old SylkParser but work with the new version.

I can also get you examples from custom maps, if needed.

@speige speige force-pushed the SylkParser_bug_fixes branch 7 times, most recently from 9711ef3 to 7110797 Compare January 5, 2025 12:05
@speige speige force-pushed the SylkParser_bug_fixes branch from 7110797 to 637c29b Compare September 6, 2025 21:03
@speige speige force-pushed the SylkParser_bug_fixes branch from 637c29b to 307faa6 Compare September 6, 2025 21:41
@Drake53
Copy link
Owner

Drake53 commented Sep 12, 2025

Sorry it took a while to respond, the SLK project is not very high on my priority list (I would've prefered to not have this library at all since it's not really specific to wc3, but I couldn't find an existing package at the time). The diff is a bit hard to read since you refactored it quite a bit, so I made a separate PR (#76) with just the fix for reading a C line which has Y instead of X. I'm sure the class could use some perf improvements and refactoring, but I prefer to keep those efforts separate from bugfixes.

@Drake53 Drake53 added the Area-Slk Related to project War3Net.IO.Slk label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Slk Related to project War3Net.IO.Slk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants