Migrate theme to AtlantaFx and ikonli#479
Merged
Merged
Conversation
WalkthroughThis PR completes a comprehensive UI framework migration from JMetro theming to Atlantafx PrimerDark, replaces ControlsFX controls with Atlantafx equivalents, converts image-based icons to FontIcon components, and refactors global stylesheet rules to use new color variable mappings throughout the JavaFX application. ChangesAtlantafx Theme and Icon System Migration
Sequence DiagramsequenceDiagram
participant OwlPlugApp as OwlPlug/Preloader
participant Application as JavaFX Application
participant PrimerDark as Atlantafx PrimerDark
participant Scene as Scene
participant Stylesheet as CSS Engine
OwlPlugApp->>Application: setUserAgentStylesheet(PrimerDark.getUserAgentStylesheet())
Application->>PrimerDark: Get stylesheet URL
PrimerDark-->>Application: Base theme stylesheet
OwlPlugApp->>Scene: Create primary Scene
OwlPlugApp->>Scene: Add owlplug.css stylesheet
OwlPlugApp->>Scene: Add owlplug-controls.css stylesheet
Scene->>Stylesheet: Apply all stylesheets in order
Stylesheet->>Stylesheet: Merge Atlantafx base + custom overrides
Note over Stylesheet: Theme variables (-color-*) and custom rules now active
🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
owlplug-client/src/main/resources/fxml/plugins/PluginsView.fxml (1)
63-80: ⚡ Quick winAdd labels (or tooltips) for icon-only display tabs.
These tabs now rely on glyphs only, which hurts discoverability and accessibility. Please add per-tab
Tooltiptext (at minimum) so users can identify List/Directories/Table modes reliably.Suggested FXML adjustment
+<?import javafx.scene.control.Tooltip?> ... <Tab fx:id="displayListTab" closable="false"> + <tooltip> + <Tooltip text="List view" /> + </tooltip> <graphic> <FontIcon iconLiteral="mdi2f-format-list-bulleted" /> </graphic> </Tab> <Tab fx:id="displayDirectoriesTab" closable="false"> + <tooltip> + <Tooltip text="Directory view" /> + </tooltip> <graphic> <FontIcon iconLiteral="mdi2f-file-tree" /> </graphic> </Tab> <Tab fx:id="displayTableTab" closable="false"> + <tooltip> + <Tooltip text="Table view" /> + </tooltip> <graphic> <FontIcon iconLiteral="mdi2v-view-module-outline" /> </graphic> </Tab>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@owlplug-client/src/main/resources/fxml/plugins/PluginsView.fxml` around lines 63 - 80, The three icon-only tabs (Tabs with fx:id displayListTab, displayDirectoriesTab, displayTableTab) lack accessible labels—add a Tooltip to each Tab (e.g., set the tooltip property on displayListTab, displayDirectoriesTab, displayTableTab) with descriptive text like "List", "Directories", and "Table" respectively; alternatively set an accessibleText or text attribute if you prefer visible labels, but ensure each Tab has a Tooltip so users can discover the mode.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@owlplug-client/src/main/resources/fxml/plugins/PluginsView.fxml`:
- Around line 63-80: The three icon-only tabs (Tabs with fx:id displayListTab,
displayDirectoriesTab, displayTableTab) lack accessible labels—add a Tooltip to
each Tab (e.g., set the tooltip property on displayListTab,
displayDirectoriesTab, displayTableTab) with descriptive text like "List",
"Directories", and "Table" respectively; alternatively set an accessibleText or
text attribute if you prefer visible labels, but ensure each Tab has a Tooltip
so users can discover the mode.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a72e5750-a759-48ce-9617-c05182266a84
⛔ Files ignored due to path filters (10)
owlplug-client/pom.xmlis excluded by!**/*.xmlowlplug-client/src/main/resources/icons/chart-white-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/connect-white-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/eye-white-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/eye2-white-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/menudot-white-64.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/share-white-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/icons/trash-white-16.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/media/plugin-placeholder.pngis excluded by!**/*.png,!**/*.pngowlplug-client/src/main/resources/media/plugin-placeholder.svgis excluded by!**/*.svg,!**/*.svg
📒 Files selected for processing (22)
owlplug-client/src/main/java/com/owlplug/OwlPlug.javaowlplug-client/src/main/java/com/owlplug/OwlPlugPreloader.javaowlplug-client/src/main/java/com/owlplug/core/controllers/MainController.javaowlplug-client/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.javaowlplug-client/src/main/java/com/owlplug/explore/controllers/SourceMenuController.javaowlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginInfoController.javaowlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginsController.javaowlplug-client/src/main/java/com/owlplug/plugin/ui/RecoveredPluginView.javaowlplug-client/src/main/java/com/owlplug/project/controllers/ProjectsController.javaowlplug-client/src/main/resources/fxml/MainView.fxmlowlplug-client/src/main/resources/fxml/Preloader.fxmlowlplug-client/src/main/resources/fxml/TaskBarView.fxmlowlplug-client/src/main/resources/fxml/dialogs/InstallStepView.fxmlowlplug-client/src/main/resources/fxml/explore/ExploreView.fxmlowlplug-client/src/main/resources/fxml/fragments/PluginPathFragment.fxmlowlplug-client/src/main/resources/fxml/plugins/DirectoryInfoView.fxmlowlplug-client/src/main/resources/fxml/plugins/PluginInfoView.fxmlowlplug-client/src/main/resources/fxml/plugins/PluginsView.fxmlowlplug-client/src/main/resources/fxml/plugins/SymlinkInfoView.fxmlowlplug-client/src/main/resources/fxml/projects/ProjectInfoView.fxmlowlplug-client/src/main/resources/fxml/projects/ProjectsView.fxmlowlplug-client/src/main/resources/owlplug.css
💤 Files with no reviewable changes (1)
- owlplug-client/src/main/java/com/owlplug/project/controllers/ProjectsController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.