Add Docker deployment for KSDB#4
Conversation
|
Thanks @yuliujpl … I need to be a reviewer, not an assignee 😉 I think I can fix that myself! |
nutjob4life
left a comment
nutjob4life
left a comment
There was a problem hiding this comment.
Whew, this is a fabulous transformation! Thanks @yuliujpl.
Take a look at the review comments and feel free to ignore the ones that don't apply or are just me "thinking out loud". Consider the rest and push any changes you feel relevant. We'll then give it another go-around and then make it live on edrn-docker.
| @@ -0,0 +1,23 @@ | |||
| FROM python:3.7-slim-bullseye | |||
There was a problem hiding this comment.
Python 3.7 is nearing end-of-life. Any chance this can run on a newer Python?
There was a problem hiding this comment.
@yuliujpl let's postpone this for now; in retrospect I'm thinking maybe we should just file this under a separate issue like "Modernize KSDB" and instead narrow the focus on making KSDB work in a Dockerized environment
| @@ -0,0 +1,30 @@ | |||
| ALTER TABLE IF EXISTS protocol | |||
There was a problem hiding this comment.
Doesn't Django's "migrations" feature make "manual" .sql like this unneeded?
There was a problem hiding this comment.
@yuliujpl let's skip this for now (we can submit a separate ticket for "Modernize KSDB")
| python manage.py test ksdb | ||
|
|
||
|
|
||
| # Docker deployment |
There was a problem hiding this comment.
This is fabulous. I tested it out and it works like a charm!
| @@ -0,0 +1,8 @@ | |||
| Django==1.9.13 | |||
There was a problem hiding this comment.
Whoa … Django 1.9 is pretty ancient (last updated December 2015). If we can't upgrade it now, let's submit a fresh ticket to remind us to upgrade it.
There was a problem hiding this comment.
@yuliujpl maybe we should skip this for now and just see if we can get the Dockerized version working
|
@yuliujpl looks like you've resolved several, nice! If there are ones you want to skip, just add a comment here in GitHub saying so. Go ahead and |
|
@nutjob4life re-review! |
2 participants
Dockerized KSDB