Improve display of build targets#262
Conversation
There was a problem hiding this comment.
Looks good to me, and a really nice improvement given the number of architectures and repos will likely keep increasing! 🥳
No major comments or things to be changed on the code but something to think about for the future:
Most instances will be running on sites where the same architectures are relevant for all repos. This doesn't necessarily have to be the case (e.g. map of zen2 and zen3 for repo A and only zen2 in repo B) and in those cases that distinction is lost with the new reporting (unless I'm missing something). This new conciseness is much better than the previous bullet list, but maybe in a future iteration it might be nice to use a "drop-down on click" approach, or have something like
zen3-repoA,repoBzen2-repoB
That's a nice idea. (Thought about that too, but then was too lazy to implement it in the first iteration.) |
|
I agree with Pedro's feedback, why not simply do something like: |
Sure. Another option would be Instance
|
Shortens the list of "build targets" (architectures and repository ids). This is shown when a PR is opened or for the command
bot: show_config. Tested in trz42/software-layer#72Example:
Old display
Instance
dev-PR254is configured to build:x86_64/amd/zen2for reponessi-2022.11-swl-deb10x86_64/amd/zen2for reponessi-2023.06-clx86_64/amd/zen2for reponessi-2023.06-swl-deb10x86_64/amd/zen2for reponessi-2023.06-swl-deb11aarch64/genericfor reponessi-2022.11-swl-deb10aarch64/genericfor reponessi-2023.06-claarch64/genericfor reponessi-2023.06-swl-deb10aarch64/genericfor reponessi-2023.06-swl-deb11aarch64/thunderx2for reponessi-2022.11-swl-deb10aarch64/thunderx2for reponessi-2023.06-claarch64/thunderx2for reponessi-2023.06-swl-deb10aarch64/thunderx2for reponessi-2023.06-swl-deb11New display
Instance
dev-PR254is configured to build for:x86_64/amd/zen2,aarch64/generic,aarch64/thunderx2nessi-2023.06-cl,nessi-2023.06-swl-deb11,nessi-2023.06-swl-deb10,nessi-2022.11-swl-deb10