initial implementation of eessi check
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexming
reviewed
Jan 30, 2026
| setting_values = get_cvmfs_config_settings(repo, specs['keys']) | ||
|
|
||
| for key in specs['keys']: | ||
| descr = CVMFS_CLIENT_SETTINGS[key] |
Collaborator
There was a problem hiding this comment.
this overwites the descr looping var from line 194, one of the two should change name
| value += " (not recommended, see https://eessi.io/docs/no-proxy)" | ||
|
|
||
| if value is None: | ||
| results.append((ERROR, f"{descr}: {UNKNOWN}")) |
Collaborator
There was a problem hiding this comment.
this is confusing, why is this case returned through results? but the other cases (line 216, line 224) are just printed out and not added to results?
| app = typer.Typer() | ||
|
|
||
|
|
||
| INFO = 'INFO' |
Collaborator
There was a problem hiding this comment.
this should better go into an eessi.config module so that it can be reused in other apps
| return (res.stdout, res.stderr, res.returncode) | ||
|
|
||
|
|
||
| def is_repo_available(repo: str): |
Collaborator
There was a problem hiding this comment.
We could also move many of these methods into an eessi.check module that can be reused in other apps. For instance I can imagine eessi.install using this check. But this can be done at a later time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.