fix(deps): replace npm-run-all with npm-run-all2 to fix shell-quote CVE-2026-9277#306
Merged
Merged
Conversation
npm-run-all is unmaintained and pinned shell-quote 1.8.1, which carries a critical advisory (CVE-2026-9277 / GHSA-w7jw-789q-3m8p). npm-run-all2 9.x depends on shell-quote ^1.8.4, so the patched version is pulled in at the source and no pnpm override is needed. npm-run-all2 ships drop-in npm-run-all / run-s / run-p binaries, so the existing build scripts are unchanged.
There was a problem hiding this comment.
Pull request overview
This PR addresses a critical shell-quote vulnerability (CVE-2026-9277 / GHSA-w7jw-789q-3m8p) by replacing the unmaintained npm-run-all with the maintained fork npm-run-all2, so the patched shell-quote is pulled in transitively without relying on overrides.
Changes:
- Replaced
npm-run-allwithnpm-run-all2@^9.0.2indevDependencies. - Updated
pnpm-lock.yamlto reflect the new dependency graph, includingshell-quote@1.8.4.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Swaps npm-run-all to npm-run-all2 while keeping scripts using the npm-run-all binary. |
| pnpm-lock.yaml | Updates the lockfile to the new resolved tree, pulling in shell-quote@1.8.4. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
package.json:52
npm-run-all2@9.0.2(as resolved inpnpm-lock.yaml) requires Node^22.22.2 || ^24.15.0 || >=26.0.0, butpackage.jsoncurrently allows>=24.0.0(which includes 24.0–24.14). This mismatch can produce engine warnings or break installs when using early 24.x releases; consider bumping the project Node engine floor to>=24.15.0(and ensure the Node version used in CI/dev matches).
"npm-run-all2": "^9.0.2",
"pagefind": "^1.5.0"
},
"engines": {
"node": ">=24.0.0"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
korbinib
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Dependabot alert #118 (
shell-quote, critical, CVE-2026-9277).Why
shell-quote@1.8.1is pulled in transitively bynpm-run-all(dev-only). Itsquote()does not escape newlines in object.opvalues (GHSA-w7jw-789q-3m8p).npm-run-allis unmaintained (last release 2018), so there is no upstream bump.Change
Swap
npm-run-allfor the maintained forknpm-run-all2@9.x, which depends onshell-quote ^1.8.4. The patched version is pulled in at the source, so nopnpm.overridesentry is needed.npm-run-all2ships drop-innpm-run-all/run-s/run-pbinaries, so thebuildanddev:buildscripts are unchanged.Verification
pnpm why shell-quote->1.8.4(was1.8.1)astro check+astro build: 0 errors, 0 warningsnode scripts/check-slugs.mjs: all names validnode scripts/test-pages.mjs: 182/182 pages, 185/185 assets OKDiff is just
package.json(one devDependency) +pnpm-lock.yaml.