Open
Conversation
keenangraham
requested changes
Apr 11, 2019
Contributor
keenangraham
left a comment
There was a problem hiding this comment.
Thanks @Bek. Since this model doesn't really learn anything I think we should either:
- Cut this down to be a very short toy example.
- Wait and incorporate what we learn from imputation challenge.
Two would be good because we should make a writeup in any case, and it might be more biologically meaningful.
Alternative approach is to write a tutorial like How to implement simple Basenji model in Keras or whatever. This would be good because there is a paper backing it up.
In any case we should incorporate the lessons from other tutorials (e.g. mounting S3 bucket on EC2) and assume the reader already knows how to do it.
Author
|
Sounds good, will get back to this after the imputation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.