Open
Conversation
zoldello
force-pushed
the
ENCD-6126--add-element-ref-to-file-details
branch
from
039feef to
a77926e
Compare
zoldello
requested review from
forresttanaka
and removed request for
forresttanaka
forresttanaka
previously approved these changes
Aug 31, 2021
Contributor
forresttanaka
left a comment
forresttanaka
left a comment
There was a problem hiding this comment.
OK, I think this works, basically adding FCC experiments’ reference files to the array of reference files. I have a couple suggestions in case you feel like taking them.
| const elementsReferences = context.elements_references; | ||
|
|
||
| if (elementsReferences) { | ||
| const elementsReferenceFiles = elementsReferences.map((elementsReference) => elementsReference.files).reduce((acc, val) => acc.concat(val), []); |
Contributor
There was a problem hiding this comment.
I see what you’re doing, though I think it’d be easier to understand in one step:
const elementsReferenceFiles = elementsReferences.reduce((accFiles, reference) => accFiles.concat(reference.files));
|
|
||
| const seriesFiles = getSeriesFiles(props.context) || []; | ||
| const datasetFiles = [...props.data, ...seriesFiles]; | ||
| const elementsReferenceFiles = props.context.elements_references?.map((elementsReference) => elementsReference.files).reduce((acc, val) => acc.concat(val), []) || []; |
Contributor
There was a problem hiding this comment.
Maybe move this into a utility function shared here and in your first change above? They do the same thing, and a well-named utility function would help documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.