Fix DataManager save task self-cancellation #5
Conversation
When `save()` is called from `_delayed_save` (which is stored in `self._save_task`), the previous logic would cancel `self._save_task`, effectively cancelling the currently running task. This caused `CancelledError` to be raised at the next `await`, aborting the save operation. This commit adds a check to ensure `self._save_task` is not cancelled if it matches the current task. Verified with a reproduction script and integration test.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Fixed a bug in
DataManager.savewhere the delayed save task would cancel itself, preventing data from being written to disk. Added a check to skip cancellation if the task to be cancelled is the current running task. Verified with a test case simulating the delayed save behavior.PR created automatically by Jules for task 11244439835533960227 started by @ENVYFGC