-
Notifications
You must be signed in to change notification settings - Fork 18
Update StandardNamesRules.rst: two identical quantities from different processes that need to be kept apart #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t processes that need to be kept apart
mkavulich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't get to this sooner. The new rule looks good.
If I am understanding the use case for the new prefix, it is for quantitative changes in value of a variable since some specified point in time? In this case, I'd propose something along the lines of change_in _X_ since _Y, where Y could be previous_timestep, start_of_forecast, etc.
If I'm not understanding the exact use case let me know.
That makes sense to me. Let's chat about this tomorrow and get this PR merged before I go on leave next week. |
nusbaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a couple optional text change requests.
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
gold2718
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay with me.
Description
Update StandardNamesRules.rst: two identical quantities from different processes that need to be kept apart.
I did not update
standard_names.xmlbecause the base variablecumulative_change_of_x_wind_due_to_convective_GWDisn't listed yet, and it doesn't make sense to addcumulative_change_of_x_wind_due_to_convective_whole_atmosphere_GWD. We can add both, but then we should add many more such variables, and that is like opening a can of worms.Questions for the reviewers: Should
cumulative_change_ofbe added, or should we use the existingchange_over_time_ininstead?Update: I removed
cumulative_change_offrom the PR, since it is not directly related to the issue that this PR addresses.Issues
Closes #79