BUILDSYS-573 now it's possible to unregister a previously registered …#117
Merged
JanFellner merged 10 commits intomainfrom Feb 12, 2026
Merged
BUILDSYS-573 now it's possible to unregister a previously registered …#117JanFellner merged 10 commits intomainfrom
JanFellner merged 10 commits intomainfrom
Conversation
…event or operation handler. A debugger break is raised when trying to register a handler for an already registered operation/event
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for unregistering previously registered ROSE operation handlers and introduces a debug trap when duplicate handler registration is attempted.
Changes:
- Extended the transport interface with
unregisterOperation(operationID). - Implemented
unregisterOperationinTSASN1Baseto remove handler mappings by ID and name. - Updated the TS ROSE generator to emit a
removeHandler()method that delegates to the transport.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| compiler/back-ends/ts-gen/gluecode/TSROSEBase.ts | Adds unregisterOperation to the transport interface so generated ROSE code can remove handlers. |
| compiler/back-ends/ts-gen/gluecode/TSASN1Base.ts | Implements unregister logic and adds a debugger trap on duplicate registration. |
| compiler/back-ends/ts-gen/gen-ts-rose.c | Generates a new removeHandler() method in the TS ROSE class that calls transport.unregisterOperation(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ccurence is notified; replaced the assertion with an output to stderr
…ature/BUILDSYS-573-ts-unset-handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added removeHandler / unregisterOperation
Added a debugger break when trying to register a handler for an already registered operation/event