Workaround for fragment encoding of eMAID type (based on OpenV2G templates) #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I’ve recently run into the same problem reported here with fragment encoding of the eMAID / EMAIDType. Specifically, the EXI stream produced by Josev does not match what the autogenerated code produces, causing interoperability issues.
I explored possible solutions and ended up implementing a workaround inspired by how OpenV2G handles it.
Instead of resolving the EXI grammar issue directly (which I understand is quite complex), I chose the following workaround:
This is essentially a copy/paste of OpenV2G’s solution into the autogenerated code, so it doesn’t fully fix the root cause at the grammar level. But it does align the output with the expected EXI stream and passes interoperability checks
Issue ticket number and link
Refer to #60
In addition, I have tested this solution on the following branch, where I have defined a new test case of eMAIDtype:
Checklist before requesting a review