fix: support riscv64gc bindgen target#4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves cross-compilation support for the Rust riscv64gc target by ensuring bindgen/libclang is invoked with a clang-compatible target triple and appropriate RISC-V ISA flags, and extends CI to build the new target via cargo-zigbuild.
Changes:
- Normalize
riscv64gctoriscv64for clang/bindgen target handling. - Pass
-march=rv64gcto bindgen when targetingriscv64gc-*. - Add
riscv64gc-unknown-linux-musl(debug/release) to the zigbuild CI matrix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
build.rs |
Adds clang-target normalization and target-specific clang args for bindgen, including RISC-V -march. |
.github/workflows/rust.yml |
Expands cross-compilation matrix to include riscv64gc-unknown-linux-musl builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5
to
15
| @@ -15,17 +15,46 @@ fn zig_target(target: &str) -> String { | |||
| } | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification