Skip to content

ECWID-161269 - add a new modified RequestKind to replace ApiCredentials #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArAkAru merged 8 commits into from
May 5, 2025
Merged

ECWID-161269 - add a new modified RequestKind to replace ApiCredentials #485

ArAkAru merged 8 commits into from
May 5, 2025

Conversation

@ArAkAru
Copy link
Contributor

@ArAkAru ArAkAru commented Apr 16, 2025 •
edited
Loading

ECWID-161269

  • create new abstract RequestKind to replace ApiCredentials
  • make ApiCredentials filed as optional with default null in public ApiClientHelper constructor (for future deletion)

@ArAkAru ArAkAru self-assigned this Apr 16, 2025
@ArAkAru ArAkAru marked this pull request as ready for review April 21, 2025 14:13
@ArAkAru ArAkAru requested a review from Alexis2004 April 21, 2025 14:13
Alexis2004
Alexis2004 requested changes Apr 22, 2025
View reviewed changes
@ArAkAru ArAkAru requested a review from Alexis2004 April 23, 2025 08:15
@ArAkAru ArAkAru merged commit d14e51a into master May 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alexis2004 Alexis2004 Alexis2004 approved these changes

Assignees

@ArAkAru ArAkAru

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArAkAru @Alexis2004