Skip to content

Conversation

@peachbits
Copy link
Contributor

@peachbits peachbits commented Nov 11, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Comment on lines +79 to +81
const key = `currency_label_${entry.value}`
const subTitle = lstrings[key as keyof typeof lstrings] ?? ''

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually build a table for this type of thing, so like:

const fiatTitles = {
  USD: lstrings.currency_label_usd,
  EUR: lstrings.currency_label_eur,
  ...
}

That was we can't "escape" into the broader strings table, because we do the lookup on a safe subset.

Now, while I would prefer to see it done this way, I won't insist on it because we are really close to the merge and we want to get this in.

@peachbits peachbits force-pushed the matthew/more-smol-tings branch from 159a361 to 58e37ac Compare November 12, 2024 01:19
@peachbits peachbits enabled auto-merge November 12, 2024 01:19
@peachbits peachbits merged commit 974303f into develop Nov 12, 2024
@peachbits peachbits deleted the matthew/more-smol-tings branch November 12, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants