Skip to content

fix(test): add missing topic field to RoutePattern#256

Open
EffortlessSteven wants to merge 1 commit intomainfrom
fix/flight-bus-routepattern-topic
Open

fix(test): add missing topic field to RoutePattern#256
EffortlessSteven wants to merge 1 commit intomainfrom
fix/flight-bus-routepattern-topic

Conversation

@EffortlessSteven
Copy link
Member

Fixes compilation error in integration_bus.rs - RoutePattern struct now requires topic field.

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compilation failure within the test suite by adapting the RoutePattern struct usage to a recent API change. The RoutePattern struct now mandates a topic field, and this PR updates the relevant test files to correctly provide this field, ensuring the tests compile and run as expected.

Highlights

  • Compilation Fix: Resolved a compilation error in integration_bus.rs by ensuring the RoutePattern struct now includes a topic field, which was recently made mandatory.
  • Test Updates: Modified existing test cases to correctly instantiate RoutePattern with the newly required topic: Topic::Any field, aligning them with the updated struct definition.
Changelog
  • crates/flight-bus/tests/integration_bus.rs
    • Imported the Topic enum from flight_bus::routing.
    • Added topic: Topic::Any to RoutePattern instantiations in integration_route_matches_axis_events_only and integration_route_source_id_filter functions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2abab2c8-0a0b-46fd-81be-6a704f3b6119

📥 Commits

Reviewing files that changed from the base of the PR and between 607f501 and 7515a81.

📒 Files selected for processing (1)
  • crates/flight-bus/tests/integration_bus.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/flight-bus-routepattern-topic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a compilation error in the integration tests by adding the new topic field to RoutePattern struct initializations. I've provided a couple of suggestions to refactor the struct creation using RoutePattern::any() and struct update syntax, which will improve code conciseness and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant