fix(test): update MockHotplugMonitor usage

[EffortlessSteven]

Fixes compilation error in hid_core_depth.rs - MockHotplugMonitor API changed.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compilation error within the hid_core_depth.rs test file. The error arose from an API change in the flight-hid crate's MockHotplugMonitor. The changes update the import statements to reflect the new API, specifically removing an unused ReconnectManager import and adding the HotplugMonitor trait import, ensuring the test suite remains functional and compatible with the latest library version.

Highlights

• API Update: Updated the usage of MockHotplugMonitor in hid_core_depth.rs to align with recent API changes in the flight-hid crate, resolving a compilation error.
• Dependency Refinement: Removed the ReconnectManager import from flight_hid::hotplug as it is no longer needed or has been refactored.
• Trait Import: Added an import for the HotplugMonitor trait, indicating its new role or requirement in the updated hotplug module.

Changelog

• crates/flight-hid/tests/hid_core_depth.rs
  • Removed ReconnectManager from the flight_hid::hotplug import statement.
  • Added HotplugMonitor to the imports within the hot_plug module.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 156d770b-c31f-4170-9662-04c9f888442d

📥 Commits

Reviewing files that changed from the base of the PR and between 607f501 and 8ddca6e.

📒 Files selected for processing (1)

• crates/flight-hid/tests/hid_core_depth.rs

---

Summary by CodeRabbit

• Tests
  • Updated test infrastructure for hotplug functionality to use an improved monitoring approach.

Walkthrough

The test file crates/flight-hid/tests/hid_core_depth.rs has been updated to replace the ReconnectManager import from flight_hid::hotplug with a HotplugMonitor import from flight_hid. No functional logic or control flow modifications were introduced.

Changes

Cohort / File(s)	Summary
Test Dependency Update crates/flight-hid/tests/hid_core_depth.rs	Replaced ReconnectManager import from flight_hid::hotplug with HotplugMonitor import from flight_hid to update test dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A monitor springs forth, fresh and bright,
Reconnection fades from sight,
Test imports dance and realign,
Hotplug harmony, now divine!
Little changes, oh what delight! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: updating MockHotplugMonitor usage to fix a compilation error in the test file.
Description check	✅ Passed	The description is directly related to the changeset, explaining that it fixes a compilation error by updating MockHotplugMonitor usage.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/flight-hid-mockhotplug-poll

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request fixes a compilation error in hid_core_depth.rs by updating imports related to MockHotplugMonitor. The changes correctly remove an unused import for ReconnectManager and add a necessary import for the HotplugMonitor trait. My review includes a suggestion to improve import consistency by consolidating the new import at the top of the file.

[gemini-code-assist]

To keep imports consistent, HotplugMonitor should be imported here at the top level along with other items from the hotplug module. This also makes the new import at line 635 unnecessary.

With this change, you can remove the use flight_hid::HotplugMonitor; line that was added inside the hot_plug module.

Suggested change

	use flight_hid::hotplug::{HotplugEvent, MockHotplugMonitor};
	use flight_hid::hotplug::{HotplugEvent, HotplugMonitor, MockHotplugMonitor};