fix: accept updated honeycomb snapshot (f32 precision)#39
Closed
EffortlessSteven wants to merge 3 commits intomainfrom
Closed
fix: accept updated honeycomb snapshot (f32 precision)#39EffortlessSteven wants to merge 3 commits intomainfrom
EffortlessSteven wants to merge 3 commits intomainfrom
Conversation
The snapshot expected roll: 1.0 but actual device mapping produces 0.9995117 due to u16-to-f32 conversion precision. Accept the correct value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoFix honeycomb snapshot assertion for f32 precision conversion
WalkthroughsDescription• Fixes pre-existing snapshot assertion failure that was blocking all PR CI runs • Updates the alpha yoke full-right-roll snapshot to accept the correct f32 precision value from u16→f32 conversion • Resolves honeycomb snapshot validation issue Diagramflowchart LR
A["u16→f32 Conversion"] -- "produces updated value" --> B["Honeycomb Snapshot"]
B -- "assertion passes" --> C["CI Pipeline Unblocked"]
File Changes |
Code Review by QodoNo Changes in PRQodo reviewed your PR and found no changes in the codeⓘ The new review experience is currently in Beta. Learn more |
There was a problem hiding this comment.
Pull request overview
Updates a Honeycomb Alpha yoke snapshot expectation to match the current 12-bit axis normalization behavior ((4095 - 2048) / 2048 ≈ 0.9995117), resolving a pre-existing snapshot assertion failure that was blocking CI for unrelated PRs.
Changes:
- Adjust the expected
rollvalue in thealpha_yoke_full_right_rolldebug snapshot from1.0to0.9995117.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Member
Author
|
Superseded by PR #68 which includes this snapshot fix plus performance baseline updates and YAML encoding fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pre-existing snapshot assertion failure blocking all PR CI runs.
The alpha yoke full-right-roll snapshot expected
oll: 1.0\ but actual u16→f32 conversion produces \