Skip to content

🛡️ Sentinel: [HIGH] Fix vulnerable constant-time equality logic #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EffortlessSteven wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

🛡️ Sentinel: [HIGH] Fix vulnerable constant-time equality logic #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63105d4
🛡️ Sentinel: [HIGH] Fix vulnerable constant-time equality logic
EffortlessSteven Mar 24, 2026
d0aaa25
🛡️ Sentinel: [HIGH] Fix vulnerable constant-time equality logic
EffortlessSteven Mar 24, 2026
a597920
🛡️ Sentinel: [HIGH] Fix vulnerable constant-time equality logic
EffortlessSteven Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .cargo/audit.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ ignore = [
"RUSTSEC-2025-0057",
# RUSTSEC-2025-0134: rustls-pemfile unmaintained - dev-only via bollard/testcontainers
# Waiting for upstream bollard fix
"RUSTSEC-2025-0134"
"RUSTSEC-2025-0134",
# RUSTSEC-2026-0066: astral-tokio-tar Insufficient validation of PAX extensions during extraction
# dev-only via testcontainers. Waiting for testcontainers upstream fix.
"RUSTSEC-2026-0066"
]
# Warn about unmaintained crates but don't fail
informational_warnings = ["unmaintained"]
15 changes: 8 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/http-auth-verifier/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[dependencies]
jsonwebtoken = { version = "10.2.0", features = ["rust_crypto"] }
serde.workspace = true
subtle = "2.6.1"
tracing.workspace = true

[dev-dependencies]
Expand Down
3 changes: 2 additions & 1 deletion crates/http-auth-verifier/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use jsonwebtoken::{EncodingKey, Header, encode};
use serde::{Deserialize, Serialize};
#[cfg(test)]
use std::time::{SystemTime, UNIX_EPOCH};
use subtle::ConstantTimeEq;

/// JWT claims used by platform auth.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
Expand Down Expand Up @@ -93,7 +94,7 @@ pub fn constant_time_eq(left: &str, right: &str) -> bool {
return false;
}

left.bytes().zip(right.bytes()).fold(0_u8, |acc, (x, y)| acc | (x ^ y)) == 0
left.as_bytes().ct_eq(right.as_bytes()).into()
}

#[cfg(test)]
Expand Down
7 changes: 6 additions & 1 deletion deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ ignore = [
# - Next review: 2026-03-18 (quarterly)
# - Action: Monitor upstream bollard crate for fix
# - Tracking: https://github.com/testcontainers/testcontainers-rs/issues
"RUSTSEC-2025-0134"
"RUSTSEC-2025-0134",
# RUSTSEC-2026-0066 (astral-tokio-tar)
# - Path: astral-tokio-tar -> testcontainers -> adapters-db-sqlx (dev-only)
# - Risk: Insufficient validation of PAX extensions during extraction. Low risk as testcontainers only uses it for copying files to/from docker containers during tests.
# - Action: Waiting for testcontainers to update to astral-tokio-tar >= 0.6.0
"RUSTSEC-2026-0066"
]
yanked = "deny"

Expand Down
Loading